#14 refactor to be more clear from what param created

skoro · Sep 9, 2024 · ddd95f9 · ddd95f9
1 parent 3df0dbc
commit ddd95f9
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/Controller/Api/V1/PaymentController.php b/src/Controller/Api/V1/PaymentController.php
@@ -115,6 +115,6 @@ public function getPaymentStatus(
         $event = $this->eventDispatcher->dispatch(new PaymentStatusEvent($order, $statusResponse));
         $statusResponse = $event->paymentStatusResponse;
 
-        return $this->json(PaymentStatusDto::makeFromResponse($paymentGateway->getId(), $statusResponse));
+        return $this->json(PaymentStatusDto::makeFromPaymentGatewayResponse($paymentGateway->getId(), $statusResponse));
     }
 }
diff --git a/src/Dto/PaymentStatusDto.php b/src/Dto/PaymentStatusDto.php
@@ -37,7 +37,7 @@ public function __construct(
     ) {
     }
 
-    public static function makeFromResponse(
+    public static function makeFromPaymentGatewayResponse(
         string $paymentGatewayId,
         ResponseInterface $response,
     ): self {

diff --git a/tests/Unit/Dto/PaymentStatusDtoTest.php b/tests/Unit/Dto/PaymentStatusDtoTest.php
@@ -19,7 +19,7 @@ public function testCastToStringPaymentResponseValues(): void
         $response->method('getCode')->willReturn(null);
         $response->method('getRawData')->willReturn(false);
 
-        $dto = PaymentStatusDto::makeFromResponse('123', $response);
+        $dto = PaymentStatusDto::makeFromPaymentGatewayResponse('123', $response);
 
         $this->assertEquals('123', $dto->paymentGatewayId);
         $this->assertEquals('', $dto->message);
@@ -40,7 +40,7 @@ public function testPaymentStatusDataAlwaysCastToArray(mixed $data, $expected):
         $response->method('getCode')->willReturn(null);
         $response->method('getRawData')->willReturn($data);
 
-        $dto = PaymentStatusDto::makeFromResponse('123', $response);
+        $dto = PaymentStatusDto::makeFromPaymentGatewayResponse('123', $response);
 
         $this->assertEquals($expected, $dto->data);
     }