Enhance Column Function Coverage with Additional Test Cases #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(tests): implement `test_func_asc_nulls_first`
- Verify sorting functionality for ascending order with NULL values positioned first.
* feat(tests): implement `test_func_asc_nulls_last`
- Verify sorting functionality for ascending order with NULL values positioned last.
…#49) * feat(tests): implement `test_func_desc_nulls_first` - Verify sorting functionality for descending order with NULL values positioned first. * feat(tests): implement `test_func_desc_nulls_last` - Verify sorting functionality for descending order with NULL values positioned last. * validate robustness and accuracy of the sorting mechanism
…#17) * feat(tests): implement `test_func_desc_nulls_first` - Verify sorting functionality for descending order with NULL values positioned first. * feat(tests): implement `test_func_desc_nulls_last` - Verify sorting functionality for descending order with NULL values positioned last. * validate robustness and accuracy of the sorting mechanism
* feat(tests): implement `test_func_like`
- Verify filter functionality using the LIKE operator.
- Ensure the filter correctly selects the name "Alice".
* validate robustness and accuracy of the LIKE filter mechanism
* feat(tests): implement `test_func_ilike`
- Verify filter functionality using the ILIKE operator.
- Ensure the filter correctly selects the name "Alice" using a case-insensitive pattern "%Ice".
* validate robustness and accuracy of the ILIKE filter mechanism
* feat(tests): implement
- Implemented a test to validate the behavior of the 'rlike' filter on a DataFrame.
- Ensured that the filter correctly identifies records with names matching the regex pattern ice.
- Added necessary setup and assertions for expected results.
* feat(tests): implement `test_func_rlike`
- Implemented a test to validate the behavior of the 'rlike' filter on a DataFrame.
- Ensured that the filter correctly identifies records with names matching the regex pattern ice.
- Added necessary setup and assertions for expected results.
* feat(tests): implement `test_func_eq`
- Verify filter functionality using the EQ operator.
* feat(tests): implement `test_func_or`
- Verify filter functionality using the OR operator.
- Ensure the filter correctly selects the name "Alice" using a case-insensitive pattern "%Ice".
* validate robustness and accuracy of the ILIKE filter mechanism
main
* feat(tests): implement `test_func_is_null`
- Implemented a test to validate the behavior of the 'is_null' filter on a DataFrame.
- Ensured that the filter correctly identifies records with null values.
- Added necessary setup and assertions for expected results.
* feat(tests): implement `test_func_is_not_null`
- Implemented a test to validate the behavior of the 'isnotnull' filter on a DataFrame.
- Ensured that the filter correctly identifies records with non-null values.
- Added necessary setup and assertions for expected results.
- Moved `isnotnull` function definition to `
// functions that require a single col argument
generate_functions!(
one_col: isnan,
isnull,
isnotnull,
...)
`
…nality(#17) * feat(tests): implement `test_func_over` - Implemented a test to validate the behavior of window functions on a DataFrame. - Ensured that the window functions (`rank` and `min`) correctly compute values within the specified window. - Added necessary setup, sorting, and assertions for expected results. * feat(tests): implement `test_func_isnan` - Implemented a test to validate the behavior of the `isnan` function on a DataFrame. - Ensured that the `isnan` function correctly identifies NaN values. - Added necessary setup and assertions for expected results.
…nctions (#17) - feat(tests): implement `test_func_cast` - Added a test to validate the behavior of casting an integer column to a string. - Ensured that the cast operation correctly transforms the data type and assigns the alias. - feat(tests): implement `test_func_alias` - Added a test to verify column aliasing functionality. - Confirmed that the DataFrame correctly applies aliases to columns. - feat(tests): implement `test_func_substr` - Added a test to validate the substring function on a string column. - Ensured that the substring operation works as expected and assigns the alias.
|
@lexara-prime-ai there was a change in the CI runner for the |
|
@sjrusso8 I just updated the PR with the fix you made for the CI runner. |
|
@lexara-prime-ai LGTM! Thanks so much for adding some much needed code coverage |
sjrusso8
approved these changes
Aug 9, 2024
|
Glad to help @sjrusso8 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces additional test cases for the column functions.
The new tests specifically evaluate the behavior of the following column functions:
asc_nulls_firstasc_nulls_lastdesc_nulls_firstdesc_nulls_lastlikeilikerlikeeqorisnotnullisnanaliascastsubstr, ensuring that they correctly identify and handle these cases.
Additionally, the
isnotnullfunction definition has been moved to the appropriate section within the code, undergenerate_functions!for functions that require a single column argument, as well as a typo on thesubtractfunction. This has been updated fromsubstracttosubtract.Fix
isnotnullfunction definition to:Related Issue(s)
Documentation
Source reference links provided by @sjrusso8
isnullandisnotnull.