feat: restructure existing modules, and add Column, Expression, and Functions modules #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move logic out of dataframe and into plan - move all nested modules into their own top level file - add logic to implement sort & orderby
- updated select to take a Vec<Column> - updated select to handle * colmns - created initial functions
sjrusso8
changed the title
sjrusso8
changed the title
sjrusso8
added a commit
that referenced
this pull request
Mar 17, 2024
…unctions modules (#1) **feat**: restructure existing modules, and add Column, Expression, and Functions modules * refactor existing modules to mirror the pyspark connector layout * move logic plan creation into the `plan` module and out of the `dataframe` module * create an `expression` module to handle `Expression` creation * create `Column` struct as a representation of a `Column` object * add traits for `alias` and `name` * create `functions` module containing the first workings of pyspark functions * add functions for `col`, `pi`, and `coalesce` * **breaking change** the `select()` trait now only excepts `Vec<Column>` * tests and examples are updated to match the change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat: restructure existing modules, and add Column, Expression, and Functions modules
planmodule and out of thedataframemoduleexpressionmodule to handleExpressioncreationColumnstruct as a representation of aColumnobjectaliasandnamefunctionsmodule containing the first workings of pyspark functionscol,pi, andcoalesceselect()trait now only exceptsVec<Column>Documentation
Pyspark Connector