New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement cross platform solution for deleting directory symlinks #37

Open

schmengler wants to merge 1 commit into sitewards:master from schmengler:cross-platform-delete

schmengler commented Oct 30, 2015

As @tomlankhorst mentioned in #31, symlinks usually should be unlinked, but directory symlinks on Windows need to be rmdird.

To satisfy all platforms, we always try unlink() first, followed by rmdir() if it did not work.


          Implement cross platform solution for deleting directory symlinks

a26b36f

Windows needs rmdir(), but we always try unlink() first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet