Skip to content

Commit

Permalink
ADHOC fix (cleaup): auto-cleanup by default
Browse files Browse the repository at this point in the history
enable auto-cleanup by default, to cover the conern highlighted on code-review:

    Looks good. But would clean up by default. I am not aware of any project
    that needs to keep the old copies. So I vote for setting to something that
    makes sense. Instead of using this role and then need to apply this config
    to get a behavior that should be the default.

Author accept the concern and applies corresponding change
  • Loading branch information
Anton Boritskiy committed Aug 22, 2019
1 parent cb60e4c commit 5a09b7d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion defaults/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,6 @@ magento_queue_consumers_cron_template: "/usr/bin/php {{ magento_app_root }}/bin/
## Deletes all installed deployable magento packages except the
## %magento_clones_to_keep% amount of latest ones + all that are newer than
## %magento_clones_cleanup_min_age%
magento_cleanup_old_clones: False
magento_cleanup_old_clones: True
magento_clones_to_keep: 5
magento_clones_cleanup_min_age: "1d"

0 comments on commit 5a09b7d

Please sign in to comment.