Improve support for ssh key files: support files with multiple keys and with already existing options #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
has any options. In this case put comma after end of our options instead of space. To tell key with options against bare key we check if key starts with (ecdsa|ssh)-. At the moment of this commit OpenSSH supports the following algorithms “ecdsa-sha2-nistp256”, “ecdsa-sha2-nistp384”, “ecdsa-sha2-nistp521”, “ssh-ed25519”, “ssh-dss” or “ssh-rsa”. If a different algorithm to be introduce to OpenSSH in future, this code would be broken. However, adding a full key parser to this subroutine seems to be overkill now.
the last key line.
|
Check out CONTRIBUTING.txt |
|
Check out [email protected] mailbox, there should be email from me dated 13 Feb 2020 |
|
FATAL: R any gitolite-admin git DENIED by fallthru Please make sure you have the correct access rights |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I've send you email 2 weeks ago - no response. Let the pull request hang around now.