Server should respond over same socker UDP socket. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running in docker (--net=bridge) on Ubuntu 22.04 we hit a problem where the TFTP responses were not routed properly. After some investigation we concluded that the response got lost because it was coming from a different (random) host:port. The patch in question re-uses the server socket for the UDP response so that reverse NAT treversal is possible in stricter network topologies.
|
Hi @zbleness , thanks for the PR and sorry for the delay. I'll look this over next week and go about merging/releasing :). |
|
I forgot about this patch as well @sirMackk . Even though it looked promising at start we could not get our e2e tests to work with py3tftp so we ended up switching to ptftplib. I guess what I'm trying to say is that we are not sure whether this patch improves your project or not as we did not follow it through. So please be careful before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running in docker (--net=bridge) on Ubuntu 22.04
we hit a problem where the TFTP responses were not
routed properly. After some investigation we concluded
that the response got lost because it was coming from a
different (random) host:port.
The patch in question re-uses the server socket for
the UDP response so that reverse NAT treversal is
possible in stricter network topologies.