Add modifiers for RTP TTL in the U/L commands #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
of the travis build stucking trying to upgrade tcpdump package.
This reverts commit ace4c8d.
This allows the Media Signalling server to tune the RTP TTL in for each stream.
of the travis build stucking trying to upgrade tcpdump package.
|
Sorry for not rebasing properly. It it's an issue, I can re-create the pull request on a clean fork. |
|
Hey, @sobomax - I want to revive this PR - should I make a new PR against latest master? |
|
Hi @razvancrainea , thanks for raising it! Fell off my radar sort of. :( I would look into converting it into sub-command for the U/L i.e. U/Lfoobar && Txyz and adding a functional test to make it complete. I can look into the former if you take care of the latter. Thanks! |
|
OK, let's do this - let me know when you get a chance to modify the command, and I will soon come back with some tests for it. Cheers! |
sobomax
added a commit
that referenced
this pull request
May 24, 2021
in the TTL setting sub-command and other places. PR: #59
sobomax
added a commit
that referenced
this pull request
May 24, 2021
sobomax
added a commit
that referenced
this pull request
May 24, 2021
sobomax
force-pushed
the
master
branch
6 times, most recently
from
55700ad
to
2131bec
Compare
sobomax
added a commit
that referenced
this pull request
Jan 23, 2023
sobomax
added a commit
that referenced
this pull request
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the Media Signalling server to tune the RTP TTL in for each stream.