Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exporting to .ics #22

Merged
merged 3 commits into from
Feb 5, 2023
Merged

Add exporting to .ics #22

merged 3 commits into from
Feb 5, 2023

Conversation

dolphingarlic
Copy link
Contributor

Temporary fix for #8

(My code is horrible, I know)

@Li357
Copy link
Contributor

Li357 commented Feb 4, 2023

what if there were two separate hooks for ics export and gcal export so when the domain stuff is figured out it'll be ready too? seems like it would be good either way to have two options (for other calendar apps) and less commented code

could we also combine toICSEvents and toGAPIEvents? seems like two or three small differences

@cjquines
Copy link
Member

cjquines commented Feb 4, 2023

agreed with @Li357 that we want to have two different hooks. biggest issue is the large blocks of code commenting, and putting it on a separate hook would mean we don't have to comment out the old code.

i dont think the shared code is enough to combine them?

@cjquines cjquines self-requested a review February 4, 2023 20:21
Copy link
Member

@cjquines cjquines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@Li357
Copy link
Contributor

Li357 commented Feb 4, 2023

maybe not, was assuming that either createEvents from ics or gapi.client.calendar.events.insert would just ignore unknown/additional properties for each event from the other format. then start, end and maybe recurrenceRule would be a conditional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants