Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve text field input #27

Closed
wants to merge 9 commits into from
Closed

Improve text field input #27

wants to merge 9 commits into from

Commits on Aug 17, 2022

  1. Add ColorChecker class. Add colorInputs ObservedObject for color stri… 

    …ngs & checking methods. Add mark or checkmark image for feedback on valid text input. Fix SwiftLint warnings.
    @W1W1-M
    W1W1-M committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    2430f97 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2022

  1. Delete ColorChecker class & ObservedObject. Delete SF symbol for colo… 

    …r text input validation. Keep SwiftLint warning fixes.
    @W1W1-M
    W1W1-M committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    2d1aafb View commit details
    Browse the repository at this point in the history

  2. Add ColorInputView. Setup ColorInputView for hex color inputs. Add co… 

    …ndition to change text color if color code is invalid. Add condition to limit character input. Add textColor to NativeTextField for use in updateNSView method. Update other ColorViews to use textColor.
    @W1W1-M
    W1W1-M committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    59b5e48 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2022

  1. Move hsl logic to ColorInputView. Delete hexColorView & hslColorView.… 

    … Add hsl ColorInputView to ColorPickerScreen. Update comments.
    @W1W1-M
    W1W1-M committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    dbf5bed View commit details
    Browse the repository at this point in the history

  2. Isolate textColor logic

    @W1W1-M
    W1W1-M committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    99f45b2 View commit details
    Browse the repository at this point in the history

  3. Update inputColorType to ColorFormat type. Delete colorType enum.

    @W1W1-M
    W1W1-M committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    26509e5 View commit details
    Browse the repository at this point in the history

  4. Move colorKeyboardShortcut to ColorFormat extension. Delete inputColo… 

    …rText filter.
    @W1W1-M
    W1W1-M committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    1cf5e65 View commit details
    Browse the repository at this point in the history

  5. Move rgb & lch logic to ColorInputView. Delete rgbColorView & lchColo… 

    …rView.
    @W1W1-M
    W1W1-M committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    32d5826 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2022

  1. Move isPreventingUpdate bool & color strings to AppState as @published … 

    …properties. Move updateColorsFromPanel method to AppState. Refactor ColorInputView & ColorPickerScreen to use @published properties from AppState. Delete unused textColor variable. Update comments.
    @W1W1-M
    W1W1-M committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    98eef57 View commit details
    Browse the repository at this point in the history