Rails 8.0 support #182
Merged
Rails 8.0 support #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
jprosevear
force-pushed
the
chore/rails-8-0
branch
from
2e1d027 to
65d8e07
Compare
jprosevear
force-pushed
the
chore/rails-8-0
branch
from
1259a2e to
cccc4d7
Compare
jprosevear
commented
Nov 17, 2024
| @@ -153,7 +153,7 @@ def notify_to(*resources) | |||
| if options[:with_devise].present? && options[:devise_default_routes].present? | |||
| create_notification_routes options, resources_options | |||
| else | |||
| self.resources target, only: :none do | |||
| self.resources target, only: [] do | |||
There was a problem hiding this comment.
This is because of rails/rails#51464 - all tests now pass, but I'm unsure of your intention @simukappu with this code
There was a problem hiding this comment.
hi @simukappu any feedback?
There was a problem hiding this comment.
I'm sorry for my very late response. I'm not sure with my original intent, but this modification seems fine. I'll merge your PR and update this gem. Thank you!
There was a problem hiding this comment.
@simukappu no problem, this gem is much appreciated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Summary
Other Information