Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jenkins_exporter_errors{type=http_requests_total} + jenkins_http_requests_total metric mix up #28

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Fix jenkins_exporter_errors{type=http_requests_total} + jenkins_http_requests_total metric mix up #28

merged 3 commits into from
Dec 12, 2023

Commits on Dec 11, 2023

  1. metrics: remove wrong jenkins_exporter_errors{type=http_requests_tota… 

    …l} metric

The jenkins_http_requests_total and jenkins_exporter_errors metrics are mixed
up.
A metric called jenkins_exporter_errors with the label http_requests_total is
incremented for every http requests.
The name implied it only counts errors but this is not the case.
The documented metric called jenkins_http_requests_total is not recorded at all.

Remove jenkins_exporter_errors metrics with the http_requests_total label.
Remove mentions of the jenkins_http_requests_total metrics in the README.

If it turns out that there is a use case for the jenkins_http_requests_total
metric it can be added back.
    @fho
    fho committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    76072ab View commit details
    Browse the repository at this point in the history

  2. http: do not use buffer when draining and discarding http body 

    Use io.Copy with io.Discard instead of io.ReadAll to drain the whole http body
when an error occurred.

This does not write the body unnecessary to a buffer in memory that will never
be used.
    @fho
    fho committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    9142e85 View commit details
    Browse the repository at this point in the history

  3. godoc: fix typos

    @fho
    fho committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    a8113bc View commit details
    Browse the repository at this point in the history