pass file info to rules

[WickyNilliams]

fixes #30

[WickyNilliams]

Sorry it took so long 😄

[ericcornelissen]

Sorry it took so long 😄

No worries, better late then never 😃

The implementation looks good. Just have one comment to potentially improve clarity and/or extensibility. Also, as mentioned in the issue, this is ideally tested as well. I'm a new maintainer and not too familiar with the test suite for the project, but I think a test like the following in custom.spec.js could be a start:

it("should provide file information", function(done){
        testSucceeds([
            (reporter, $, ast, info) => {
                expect(info).toExist();
                expect(info.hasOwnProperty("path")).toBe(true);
                done();
            }
        ]);
    });

[WickyNilliams]

I added a test as you asked.

I struggled to get the test to work properly (it would dump a load of junk to the console) using the format you suggested, so instead i throw an Error if either info, or info.filepath is not present. Hope that's ok!

[ericcornelissen]

I added a test as you asked.

Thanks!

I struggled to get the test to work properly (it would dump a load of junk to the console) using the format you suggested, so instead i throw an Error if either info, or info.filepath is not present. Hope that's ok!

Apologies if my test didn't work for you. Anyway, I do quite like the way you did it so no problems there.

Could you just remove the use of .only from and add semicolons ; where they're missing in the test suite?

[ericcornelissen]

This looks good to me now @WickyNilliams, thanks!

I'll leave this open for a few more days (at least until 2021-11-15) to give @birjolaxew a chance to review it as well.

[birjj]

Haven't had the chance to actually test, but the code looks good to me. I'll let @ericcornelissen merge.

[github-actions]

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀