Make configuration optional #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a test for each of the SVGLint API functions to verify they work if
no config is provided - with the expected behaviour being the same as
that of providing the config `{}` explicitly.
Update the API so that the linting configuration is optional. Currently, the config falls back to an empty object.
Update the SVGLint CLI to not require a configuration file. The `getConfigurationFile` function was updated to output a special value (`false`) if no configuration file is found. When the CLI, using this function, detects there's no config file it will not try to read (`require`) that file.
Update the CLI such that *if* a configuration file path is specified, i.e. the `--config` option is used, then the configuration file must exist. If it does not exist, the CLI will exist with a non-zero exit code, after logging an error. If `--config` is not used the CLI behaviour is unchanged.
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10
Relates to #25