Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some mangling, refactoring and fix PDF download #287

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

mondeja
Copy link
Member

@mondeja mondeja commented Apr 5, 2023

Contributes to #286

  • Fix PDFs not being downloaded using the download mode button.
  • Remove xmlns from inline SVGs (see this question on StackOverflow)
  • Refactor some code.
  • Remove duplication of download link href and preview src.
  • Merge order-color and order-alpha attributes into one o attribute separating the values by a - character.

Size before

  index.html (2.17 MiB)
  es/index.html (2.2 MiB)
  fr/index.html (2.19 MiB)
  it/index.html (2.19 MiB)
  pt/index.html (2.18 MiB)
  zh-CN/index.html (2.18 MiB)
  zh-TW/index.html (2.17 MiB)
  zh-HK/index.html (2.17 MiB)
  ja-JP/index.html (2.2 MiB)

Size after

  index.html (1.96 MiB)
  es/index.html (1.99 MiB)
  fr/index.html (1.97 MiB)
  it/index.html (1.98 MiB)
  pt/index.html (1.97 MiB)
  zh-CN/index.html (1.97 MiB)
  zh-TW/index.html (1.96 MiB)
  zh-HK/index.html (1.96 MiB)
  ja-JP/index.html (1.99 MiB)

@mondeja mondeja added bug Something isn't working performance Issues or pull request regarding performance labels Apr 5, 2023
@mondeja mondeja mentioned this pull request Apr 5, 2023
8 tasks
@mondeja mondeja merged commit b1c108e into simple-icons:master Apr 5, 2023
@mondeja mondeja deleted the grid-mangling-1 branch April 5, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working performance Issues or pull request regarding performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant