Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Suggestion] Add support to download icons in a specified color #31

Closed
1 of 4 tasks
ericcornelissen opened this issue Jan 24, 2021 · 2 comments
Closed
1 of 4 tasks

[Suggestion] Add support to download icons in a specified color #31

ericcornelissen opened this issue Jan 24, 2021 · 2 comments
Labels
enhancement New feature or request in discussion There is an ongoing discussion that should be finished before we can continue

Comments

@ericcornelissen
Copy link
Contributor

ericcornelissen commented Jan 24, 2021 •
edited
Loading

ℹ️ If you're interested in this feature, please leave comment or add a 👍

Kind of issue

  • Feature
  • Bug
  • Design
  • Other, namely:

Description

Following an idea that appeared in this redesign proposal add the option to download SVGs in a specific color, rather than no color/black.
@ericcornelissen ericcornelissen added the enhancement New feature or request label Jan 24, 2021
@ericcornelissen ericcornelissen changed the title Add support to download icons in a specified color [Suggestion] Add support to download icons in a specified color Jan 24, 2021
@ericcornelissen ericcornelissen added the in discussion There is an ongoing discussion that should be finished before we can continue label Jan 24, 2021
This was referenced Jan 26, 2021
Closed
Closed
@jorgeamadosoria
Copy link
Contributor

I wouldn't add this in the current website.
Maybe if the icon detail view is ever implemented (#43), that would be a good place for this (and other) buttons

@jorgeamadosoria
Copy link
Contributor

jorgeamadosoria commented Oct 17, 2021 •
edited
Loading

Given an apparent lack of interest in working on this feature, can we close it?
Personally, I don't think this is necessary. If someone needs the icon in a particular color, they can always edit the SVG manually or apply a CSS rule. There is no point in offering a feature for this. Brand color (which is a different ticket) should be enough.

After a brief discussion with @ericcornelissen, I'll be closing this ticket in a few days, unless any other @simple-icons/maintainers has a different opinion on the matter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request in discussion There is an ongoing discussion that should be finished before we can continue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ericcornelissen @jorgeamadosoria