-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Suggestion] Download a collection of icons at once #42
Comments
Users are familiar with this kind of option (think Dropbox or Google Drive), but yes, most probably you don't actually do that, because if you need more than a handful you just use the Github zip download option, or a package. I'm even wondering how big the dev cost would be for us (or are there ootb packages for that out there?). |
You can zipping on the fly client side, see for example JSZip. |
I don't think it is fair to assume users will know about the GitHub zip download option, and even so having to download everything if you just need 10 or 20 is unnecessary (and depending on your internet connect, very annoying). If we really think (or have evidence that) users that manually download many SVGs in one sitting, I think we should consider adding it. The priority of this feature may change depending on alternatives such as GitHub zip download, but do not in my opinion remove the need for us to support it.
In my experience there are plenty of packages for various programming languages for creating |
Oh wow, I stand corrected. @ericcornelissen: I'm not against adding it! Quite the contrary. In my thoughts it just seemed more costly, dev time wise. |
Speaking as an user, this is actually something I would like to see. |
After thinking about this for a bit, I see a problem with it, namely: I still think that we could create preset collections to download (like programming languages, US companies, Airlines, etc.) although I understand that this is subjective and may be hard to decide where certain items can go. Another thing that can be done is just provide a button for downloading a zip file with all visible icons, and let people search for a group of icons they would like to download. The easiest thing would be to just download all icons in a zip file, zipped in the client or pre-zipped since it would contain all icons. what does everyone thinks about this @simple-icons/maintainers ? |
Could we perhaps have a quick download button for downloading a single icon without adding it to the cart? |
we have that on each card already, the download button for each icon. |
I think allowing users to add to a collection of icons for download is still a nicer experience than individually downloading each one. |
That's what I thought at first, too. I guess that you could argue that a collection that works as a cart in this way would give the user a chance to check the icons before downloading or something, but is that really that necessary, in a website that downloads icons for free? I just don't see how the user is having a better time or experience doing this than just downloading the icons one by one like they need to do now. |
I guess there isn't a good enough reason for collections then. I'm unable to think of why using a cart would be a better experience than individually downloading. |
That's where I'm at now, as well. For example, a colection of icons that allow downloading by preset categories. Another case could be favorite icons thay each user could keep in their local storage, but that doesn't really help a pot unless we allow for server side user preferences. Or maybe the collection could allow user settings for download, like colored icons, pdf/svg/png per icon, I don't know. Not really good choices, so I'm as out of ideas as you @sachinraja . I guess I'm going to give this ticket another month to see if any @simple-icons/maintainers come up with something or express interest, and if not, I"ll close it and move on |
Reading the original comment, they have an user case I hadn't considered, which is to build a svg sprite out of selected icons. |
Unless interest is expressed in keeping this issue open, I think it can be closed as per the last few comments exchanged between @sachinraja and I. I fail to see a good reason to include the custom set download. Partial features for which this could be useful are: Preset collections and custom SVG sprites. If those are considered to be of interest (or are requested) then we can open specific issues for them separate from this, which is more general. I'm marking this PR as abandoned and will be closing it in the first week of December, 2021, unless discussion happens or opposition is voiced |
As per the previous comment, I'm closing this issue. It can always be reopened if someone requests a similar feature. |
ℹ️ If you're interested in this feature, please leave comment or add a 👍
Kind of issue
Description
As per this comment: add functionality to allow users to select an icon to be included a "collection", and then have the ability to download all the icons in the collection at once (probably as
.zip
). It could be nice to provide download options such as #31, #32, #33 for the collection (without it affecting anything else), similar to #43.As per this comment the benefits of this are not super clear, as it takes up space in the UI while most users probably only download a handful of icons when visiting the website...
The text was updated successfully, but these errors were encountered: