Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: translate glyphs before the negative y scaling to bottom align o… #171

Merged
merged 2 commits into from
Jun 30, 2022

Conversation

eburghar
Copy link
Contributor

See #170

@eburghar
Copy link
Contributor Author

eburghar commented Jun 19, 2022

I changed the svg template because a negative ascent and a descent of the size of the glyps was quiet weird. Normally the ascent should be the full height and the descent a fraction of that height where the baseline should be positioned.

ascent, descent and baseline

Copy link
Member

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

I've only a question. Why should not be the descent value 0 as we are dealing with icons? I've done a comparison adding border: 1px solid black to i.si elements and, at least in the test page, inside their same DOM elements, icons look centered when setting descent="0":

descent="240"

image

descent="0"

image

@eburghar
Copy link
Contributor Author

eburghar commented Jun 21, 2022

Yes, you are right. It is better. I think I saw that setting in awesome font but my guess is that each icon define its own baseline and descent in that case is set to the max value. As none of the icons of simple icons set a baseline a descent of 0 is definitively better.

@ineshbose
Copy link

Sorry for the bump and ping @mondeja but it's been a week and hoping to have this merged soon please so the LaTeX wrapper can also implement the fix as well! 😄

Copy link
Member

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! 👍🏼

It will be released the next Sunday or Monday.

@mondeja mondeja merged commit aaad1af into simple-icons:develop Jun 30, 2022
@mondeja mondeja added the bug Something isn't working label Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants