Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update release note format #86

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Update release note format #86

merged 2 commits into from
Nov 28, 2024

Conversation

LitoMore
Copy link
Member

@LitoMore LitoMore commented Nov 28, 2024 •
edited
Loading

Changes

  • Add icons count to the section title
  • Change section title to <h2> since the release note title is <h1>

Preview

npm run preview
## 7 new icons

- AfterShip (#11526) (@anhthang)
- Game Science (#11792) (@LitoMore)
- Honeygain (#11167) (@anhthang)
- MapTiler (#11863) (@DerBraky)
- Silver Airways (#11399) (@sebastien46)
- U.S. News (#11110) (@uncenter)
- Wine (#11899) (@DerBraky)

## 4 updated icons

- About.me (#11667) (@sebastien46)
- Bombardier (#11691) (@PratyushJayachandran)
- Instagram (#12226) (@rushikeshtagadkar)
- VirtualBox (#11889) (@DerBraky)

@LitoMore LitoMore added the meta Issues or pull requests regarding the project or repository itself label Nov 28, 2024
@LitoMore LitoMore requested a review from mondeja November 28, 2024 09:07
mondeja
mondeja reviewed Nov 28, 2024
View reviewed changes
Copy link
Member

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but you need to update the tests.

@LitoMore LitoMore requested a review from mondeja November 28, 2024 22:24
mondeja
mondeja approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, feel free to merge. And don't forget to create a new release!

@LitoMore LitoMore merged commit dde8f33 into simple-icons:master Nov 28, 2024
3 checks passed
@LitoMore LitoMore deleted the update-format branch November 28, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mondeja mondeja mondeja approved these changes

Assignees
No one assigned
Labels
meta Issues or pull requests regarding the project or repository itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LitoMore @mondeja