Allow for multiple nested ul and ol lists.
#39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had two `ul` elements inside of a `li` and bonsai was only recognizing the last one. If you look at line 160, you can see that it sets the `subList` data value as the last of the subLists and then the other sub lists are ignored with expanded and collapsing. The change I made fixes the issue but I'm sure you know better if A) there's a better way to solve this or B) what might break with this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had two
ulelements inside of aliand bonsai was only recognizing the last one. If you look at line 160, you can see that it sets thesubListdata value as the last of the subLists and then the other sub lists are ignored with expanded and collapsing.The change I made fixes the issue but I'm sure you know better if A) there's a better way to solve this or B) what might break with this change.