Skip to content

Commit

Permalink
Temporarily disable tests in CI
Browse files Browse the repository at this point in the history
The tests take two hours to run now that we have net461, net6.0, and
net8.0 target frameworks. They're all passing except for one that's
known to be flaky and timing-dependant, so it's safe to disable them
while we work on fixing the part of the build that comes after the
tests. Then once that's working we'll revert this commit.
  • Loading branch information
rmunn committed Mar 14, 2024
1 parent 457309a commit 376030a
Showing 1 changed file with 17 additions and 13 deletions.
30 changes: 17 additions & 13 deletions .github/workflows/ci+cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,20 +52,24 @@ jobs:
# Unfortunately we need two test steps because we need different filters.
# We could conditionally set an environment variable, but unfortunately
# the syntax to access that is different on Windows vs Linux.
- name: Test on Linux
run: dotnet test --no-build -c Release --filter TestCategory!=RequiresUI -- NUnit.TestOutputXml=TestResults
if: matrix.os == 'ubuntu-latest'

- name: Test on Windows
run: dotnet test --no-build -c Release --filter TestCategory!=SkipOnBuildServer -- NUnit.TestOutputXml=TestResults
if: matrix.os == 'windows-latest'

- name: Upload Test Results
if: always()
uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8 # v3.1.0
with:
name: Test Results (${{matrix.os}})
path: "**/TestResults/*.xml"
# Tests disabled temporarily while we iterate on the build process. They're all working except for the one flaky one,
# but they take two hours to run so it's hard to iterate. - 2024-03 RM
# CODE REVIEW NOTE: If I forget to uncomment this block before submitting the PR for review, yell at me in code review.
# - name: Test on Linux
# run: dotnet test --no-build -c Release --filter TestCategory!=RequiresUI -- NUnit.TestOutputXml=TestResults
# if: matrix.os == 'ubuntu-latest'

# - name: Test on Windows
# run: dotnet test --no-build -c Release --filter TestCategory!=SkipOnBuildServer -- NUnit.TestOutputXml=TestResults
# if: matrix.os == 'windows-latest'

# - name: Upload Test Results
# if: always()
# uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8 # v3.1.0
# with:
# name: Test Results (${{matrix.os}})
# path: "**/TestResults/*.xml"

- name: Checkout Chorus Help # required for Chorus Merge Module
uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # v3.0.2
Expand Down

0 comments on commit 376030a

Please sign in to comment.