Trie log preload timeout #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
The comment was generated by Greptile
PR Summary
Introduced a timeout mechanism for trie log preloading and adjusted the Bonsai Trie log pruning window size.
- Timeout Mechanism: Added a timeout for trie log preloading in
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/trie/diffbased/common/trielog/TrieLogPruner.javausingScheduledExecutorService. - Exception Handling: Throws
TimeoutExceptionif preloading exceeds 30 seconds, ensuring the process doesn't run indefinitely. - Logging Enhancements: Improved logging for better visibility into preloading and pruning processes.
- Configuration Change: Reduced
DEFAULT_BONSAI_TRIE_LOG_PRUNING_WINDOW_SIZEfrom 30,000 to 5,000 inethereum/core/src/main/java/org/hyperledger/besu/ethereum/worldstate/DataStorageConfiguration.java, impacting performance and resource usage.
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Add unit tests to the EXTCODE* series operations. Also, put all EVM operations tests in the proper package. Signed-off-by: Danno Ferrin <[email protected]>
…ction pool (hyperledger#7359) * Introduce score for pending transactions Signed-off-by: Fabio Di Fabio <[email protected]> * Introduce score for pending transactions Signed-off-by: Fabio Di Fabio <[email protected]> * Update package javadoc Signed-off-by: Fabio Di Fabio <[email protected]> --------- Signed-off-by: Fabio Di Fabio <[email protected]>
…yperledger#7377) * Update GeneralStateTestCaseEipSpec for use in linea-arithmetization Signed-off-by: Gaurav Ahuja <[email protected]> * formatting Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Gaurav Ahuja <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]>
…meout Signed-off-by: Simon Dudley <[email protected]>
…act (hyperledger#7380) Signed-off-by: garyschulte <[email protected]>
…#7357) There is still a startup error when bonsai-limit-trie-logs-enabled is explicitly set to true --------- Signed-off-by: Simon Dudley <[email protected]>
* Do not maintain connections to bootnodes Signed-off-by: Matthew Whitehead <[email protected]> * Update changelog entry Signed-off-by: Matthew Whitehead <[email protected]> --------- Signed-off-by: Matthew Whitehead <[email protected]> Co-authored-by: Stefan Pingel <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
There was a problem hiding this comment.
The comment was generated by Greptile
PR Summary
(updates since last review)
The recent changes focus on enhancing transaction management and peer discovery mechanisms, along with some refactoring for better code organization.
- Transaction Penalization: Introduced penalization logic for transactions in
ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/layered/AbstractPrioritizedTransactions.javaand related classes, improving transaction prioritization. - Peer Discovery: Added
includeBootnodesOnPeerRefreshoption inethereum/p2p/src/main/java/org/hyperledger/besu/ethereum/p2p/config/DiscoveryConfiguration.javato enhance peer discovery in PoA networks. - Refactoring: Moved multiple test files from
operationstooperationpackage inevm/src/test/java/org/hyperledger/besu/evm/operation, aligning with naming conventions. - EIP-3540 Support: Updated
ExtCodeCopyOperation.java,ExtCodeHashOperation.java, andExtCodeSizeOperation.javato support EIP-3540 semantics, ensuring compatibility with new Ethereum improvements. - New Tests: Added
TrieLogSubCommandTest.javato verifybonsai-limit-trie-logs-enabledconfiguration handling in various subcommands.
72 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@greptileai
PR description
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests