Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - libp2p upgrade + gossipsub interval fix #3012

Conversation

divagant-martian
Copy link
Collaborator

Issue Addressed

Lighthouse gossiping late messages

Proposed Changes

Point LH to our fork using tokio interval, which 1) works as expected 2) is more performant than the previous version that actually worked as expected
Upgrade libp2p

Additional Info

libp2p/rust-libp2p#2497

fix rpc NB impl

use commit hash

update tests

more test updates

more test updates
@divagant-martian divagant-martian force-pushed the libp2p-gossipsub-interval-hotfix branch from 65f502a to caf0f4b Compare February 10, 2022 00:49
Copy link
Member

@AgeManning AgeManning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Lets get this guy in to save us from all the pain!

@AgeManning AgeManning added the ready-for-merge This PR is ready to merge. label Feb 10, 2022
@AgeManning
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Feb 10, 2022
## Issue Addressed
Lighthouse gossiping late messages

## Proposed Changes
Point LH to our fork using tokio interval, which 1) works as expected 2) is more performant than the previous version that actually worked as expected
Upgrade libp2p 

## Additional Info
libp2p/rust-libp2p#2497
@bors bors bot changed the title libp2p upgrade + gossipsub interval fix [Merged by Bors] - libp2p upgrade + gossipsub interval fix Feb 10, 2022
@bors bors bot closed this Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants