Update Dockerfile for Better Compatibility #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to allow easier building for alternate architectures
- Update image to use node:{version}-alpine
- Add community repo so openjdk11-jdk can be added
- Add java_home env for jlink to be found
- Add sed command to flip download to false
Currently the gradle step that downloads node is only compatible with amd64. These changes will make node part of the base image and flip the download to false allowing for the build to complete on architectures such as ARM64.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to allow easier building for alternate architectures
Currently the gradle step that downloads node is only compatible with amd64. These changes will make node part of the base image and flip the download to false allowing for the build to complete on architectures such as ARM64.