Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CF SDK: Leave call by id #1045

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

CF SDK: Leave call by id #1045

wants to merge 6 commits into from

Conversation

iAmmar7
Copy link
Collaborator

@iAmmar7 iAmmar7 commented May 7, 2024

Description

Allow the user to leave the call by passing the ID. This method integrates the call.end API.

Type of change

  • Internal refactoring
  • Bug fix (bugfix - non-breaking)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Code snippets

const client = await SignalWire({ ... })

const call = await client.dial({ ... })

await roomObj.leaveCallById(some_call_id)

Copy link

changeset-bot bot commented May 7, 2024

⚠️ No Changeset found

Latest commit: 747d0ce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@iAmmar7 iAmmar7 changed the title WIP: CF SDK: Leave call by id CF SDK: Leave call by id May 10, 2024
@iAmmar7 iAmmar7 requested a review from jpsantosbh May 10, 2024 15:05
@iAmmar7 iAmmar7 closed this May 13, 2024
@iAmmar7 iAmmar7 reopened this May 13, 2024
@iAmmar7 iAmmar7 marked this pull request as draft May 13, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant