Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structured logging #173

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Structured logging #173

merged 1 commit into from
Jun 18, 2024

Conversation

sergelogvinov
Copy link
Collaborator

@sergelogvinov sergelogvinov commented Jun 17, 2024 •
edited
Loading

Pull Request

What? (description)

Why? (reasoning)

https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md

Acceptance

Please use the following checklist:

  • you linked an issue (if applicable)
  • you included tests (if applicable)
  • you ran conformance (make conformance)
  • you linted your code (make lint)
  • you linted your code (make unit)

See make help for a description of the available targets.

@sergelogvinov
refactor: contextual logging
3b20bb0 
Migrate to contextual logging.

Signed-off-by: Serge Logvinov <[email protected]>
@sergelogvinov sergelogvinov marked this pull request as ready for review June 18, 2024 13:42
@sergelogvinov sergelogvinov requested a review from frezbo June 18, 2024 13:42
frezbo
frezbo approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@frezbo frezbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to print the errors anymore?

@sergelogvinov
Copy link
Collaborator Author

/m

@talos-bot talos-bot merged commit 3b20bb0 into siderolabs:main Jun 18, 2024
3 checks passed
@sergelogvinov sergelogvinov deleted the logging branch June 18, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frezbo frezbo frezbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sergelogvinov @frezbo @talos-bot