Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose metrics #157

Merged
merged 1 commit into from
May 7, 2024
Merged

feat: expose metrics #157

merged 1 commit into from
May 7, 2024

Conversation

sergelogvinov
Copy link
Collaborator

Pull Request

What? (description)

Why? (reasoning)

Acceptance

Please use the following checklist:

  • you linked an issue (if applicable)
  • you included tests (if applicable)
  • you ran conformance (make conformance)
  • you linted your code (make lint)
  • you linted your code (make unit)

See make help for a description of the available targets.

@sergelogvinov sergelogvinov changed the title Metrics feat: expose metrics May 5, 2024
@sergelogvinov sergelogvinov marked this pull request as ready for review May 6, 2024 07:14
@sergelogvinov sergelogvinov requested a review from frezbo May 6, 2024 07:15
frezbo
frezbo reviewed May 6, 2024
View reviewed changes
docs/metrics.md Outdated

This document is a reflection of the current state of the exposed metrics of the Talos CCM.

## Gater metrics from talos-cloud-controller-manager
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Gater metrics from talos-cloud-controller-manager
## Gather metrics from talos-cloud-controller-manager

frezbo
frezbo approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@frezbo frezbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll also have @smira take a look tomorrow

@sergelogvinov sergelogvinov force-pushed the metrics branch 3 times, most recently from 9a98ad1 to 14e7168 Compare May 6, 2024 07:46
@sergelogvinov
feat: expose metrics
0e8728c 
Expose API call metrics and node CSR approve statistics.

Signed-off-by: Serge Logvinov <[email protected]>
@sergelogvinov
Copy link
Collaborator Author

/m

@talos-bot talos-bot merged commit 0e8728c into siderolabs:main May 7, 2024
4 checks passed
@sergelogvinov sergelogvinov deleted the metrics branch May 7, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frezbo frezbo frezbo approved these changes

@smira smira smira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sergelogvinov @smira @frezbo @talos-bot