feat: node transformer feature flags #156
Merged
+89
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergelogvinov
force-pushed
the
features-flags
branch
from
0c7266e to
a8d00a4
Compare
frezbo
reviewed
May 6, 2024
pkg/transformer/transformer.go
Outdated
| // NodeFeaturesFlagSpec represents the node features flags. | ||
| type NodeFeaturesFlagSpec struct { | ||
| // PublicIPDiscovery try to find public IP on the node | ||
| PublicIPDiscovery *bool `yaml:"publicIPDiscovery,omitempty"` |
There was a problem hiding this comment.
we could just make this non-pointer and simplify the check
There was a problem hiding this comment.
I thought it will use as true/false/undefined value to set default in future.
Currently we have false as default. And i've changed it to non pointer.
Thanks.
frezbo
approved these changes
May 6, 2024
Introduce feature flags: * PublicIPDiscovery enables the Cloud Controller Manager (CCM) to identify global/public IPs on the node. Signed-off-by: Serge Logvinov <[email protected]>
sergelogvinov
force-pushed
the
features-flags
branch
from
a8d00a4 to
85e2022
Compare
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce feature flags:
Pull Request
What? (description)
Why? (reasoning)
Acceptance
Please use the following checklist:
make conformance)make lint)make unit)