feat: deploy without cni #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run TalosCCM Deployment Without CNI Readines. When the useDaemonSet parameter is set to true, CCM will use the node IP to access Kubernetes and Talos API. Signed-off-by: Serge Logvinov <[email protected]>
frezbo
reviewed
Feb 5, 2024
| @@ -65,6 +65,12 @@ spec: | |||
| valueFrom: | |||
| fieldRef: | |||
| fieldPath: status.podIP | |||
| - name: KUBERNETES_SERVICE_HOST | |||
There was a problem hiding this comment.
isn't it easier to use hostnetwork?
There was a problem hiding this comment.
KUBERNETES_SERVICE_HOST and KUBERNETES_SERVICE_PORT are using for go-kubernetes client connection.
Node can have IPv4 or IPv6 and status.podIP will have preferred IP to reach the node.
I am not sure about 127.0.0.1 or ::1 addresses.
What do you think?
There was a problem hiding this comment.
If it's better I'm all for it :thumbsup
frezbo
approved these changes
Feb 5, 2024
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run TalosCCM Deployment Without CNI Readines.
When the useDaemonSet parameter is set to true, CCM will use the node IP to access Kubernetes and Talos API.
Pull Request
What? (description)
Why? (reasoning)
Acceptance
Please use the following checklist:
make conformance)make lint)make unit)