Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support bundle download button to cluster overview #436

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

utkuozdemir
Copy link
Member

Allow downloading support bundles from the UI.
Part of #75.

@utkuozdemir
Copy link
Member Author

@Unix4ever not sure if this will be useful at all, but handing this over to you as it is beyond my FE/design skills.

@Unix4ever Unix4ever marked this pull request as ready for review July 24, 2024 16:59
@Unix4ever Unix4ever force-pushed the support-bundle-button branch 2 times, most recently from 4b32cdf to 93d3d7e Compare July 24, 2024 17:01
Allow downloading support bundles from the UI.
Part of siderolabs#75.

Signed-off-by: Utku Ozdemir <[email protected]>
Co-authored-by: Artem Chernyshev <[email protected]>
@Unix4ever
Copy link
Member

Polished the UI, fixed the bug related to the download not being canceled after you close the modal.

Final UI:

Screen.Recording.2024-07-24.at.19.52.00.mov

@frezbo
Copy link
Member

frezbo commented Jul 24, 2024

Polished the UI, fixed the bug related to the download not being canceled after you close the modal.

Final UI:
Screen.Recording.2024-07-24.at.19.52.00.mov

Cool, can we use nodenames instead of siderolink addresses?

@Unix4ever
Copy link
Member

Unix4ever commented Jul 24, 2024

Cool, can we use nodenames instead of siderolink addresses?

Well, that's actually node internal IP, it's just how Talos emulator shows it.
It's how Talos support bundle collector works, so we might need to map it in Omni somehow.

@Unix4ever
Copy link
Member

/m

@talos-bot talos-bot merged commit 19a72be into siderolabs:main Jul 24, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants