-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mergerfs): Add extension #428
Conversation
This will fix siderolabs#396 Signed-off-by: Skyler Mäntysaari <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing documentation, would need some docs on how to test this, so that tests maybe added in talos side
And I think we should build from source (it shouldn't be crazy given that it's C++). |
I'm also little confused as to why it would try to create /var/mnt, instead of bind mounting it..
apiVersion: v1alpha1
kind: ExtensionServiceConfig
name: mergerfs
configFiles:
- content: |-
[mount]
path = /var/mnt/merged
fstype = fuse.mergerfs
options = defaults,allow_other,use_ino,nonempty,minfreespace=50G,category.create=mfs,moveonenospc=true,fsname=mergerFS
[paths]
source = /var/mnt/disk*
mountPath: /usr/local/etc/mergerfs/config.ini |
you'd need a dependency on |
That results in other problems as cri will not come up if all user disks are not able to be mounted because they're eg non xfs. The whole point of mergerfs is to use disks that are separate and potentially different file systems. Related: siderolabs/talos#9023 |
Signed-off-by: Skyler Mäntysaari <[email protected]>
Closed due to better wait for siderolabs/talos#8367 and this requires a lot of the filesystem tools to exist on rootfs which they currently don't. Like ext* related utilities, and btrfs to name a few. Also related to: siderolabs/talos#9026 |
This will fix #396