chore: limit aws elb name to 32 characters #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimJones
reviewed
Jun 27, 2024
| @@ -110,7 +110,7 @@ module "elb_k8s_elb" { | |||
| source = "terraform-aws-modules/elb/aws" | |||
| version = "~> 4.0" | |||
|
|
|||
| name = "${var.cluster_name}-k8s-api" | |||
| name = substr("${var.cluster_name}-k8s-api", 0, 32) | |||
There was a problem hiding this comment.
How long are the cluster names?? 😅
There was a problem hiding this comment.
talos-e2e-6aeac191-aws-nonfree-nvidia-k8s-api something like this from ci,
TimJones
approved these changes
Jun 27, 2024
Unix4ever
approved these changes
Jun 27, 2024
|
/m |
ELB names cannot be more than 32 characters. Signed-off-by: Noel Georgi <[email protected]>
frezbo
force-pushed
the
chore/limit-aws-elb-size
branch
from
8c2c5b0 to
e7f8d3e
Compare
|
/m |
1 similar comment
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ELB names cannot be more than 32 characters.