Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grafana: remove allow_embedding: true #46

Merged
merged 1 commit into from
Jun 3, 2024
Merged

grafana: remove allow_embedding: true #46

merged 1 commit into from
Jun 3, 2024

Conversation

willbush
Copy link
Contributor

From my testing it doesn't seem to be necessary:

https://github.com/grafana/grafana/blob/990ad860df25286da6c54a2085c16ba2cfc1015d/conf/sample.ini#L344

set to true if you want to allow browsers to render Grafana in a , <iframe>, or . default is false.

@smira smira requested review from TimJones and utkuozdemir May 30, 2024 12:38
@TimJones TimJones force-pushed the grafana/remove-allow-embedding branch from 25c0a27 to caa485c Compare May 30, 2024 13:49
TimJones
TimJones approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@TimJones TimJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

This is a remanent from when Omni used iframes to expose the in-cluster services. Since we no longer do that this can be cleaned up for sure!

@TimJones
Copy link
Member

/ok-to-test

@TimJones TimJones force-pushed the grafana/remove-allow-embedding branch from caa485c to 930d941 Compare May 30, 2024 14:09
@TimJones
Copy link
Member

/m

@willbush @utkuozdemir
grafana: remove allow_embedding: true
a71a7f5 
From my testing it doesn't seem to be necessary:

https://github.com/grafana/grafana/blob/990ad860df25286da6c54a2085c16ba2cfc1015d/conf/sample.ini#L344

>set to true if you want to allow browsers to render Grafana in a <frame>, <iframe>, <embed> or <object>. default is false.

Signed-off-by: Will Bush <[email protected]>
Signed-off-by: Tim Jones <[email protected]>
Signed-off-by: Utku Ozdemir <[email protected]>
@utkuozdemir utkuozdemir force-pushed the grafana/remove-allow-embedding branch from 930d941 to a71a7f5 Compare June 3, 2024 13:49
@utkuozdemir
Copy link
Member

/m

@talos-bot talos-bot merged commit a71a7f5 into siderolabs:main Jun 3, 2024
1 check passed
@willbush willbush deleted the grafana/remove-allow-embedding branch June 4, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utkuozdemir utkuozdemir utkuozdemir approved these changes

@TimJones TimJones TimJones approved these changes

Assignees

@TimJones TimJones

@utkuozdemir utkuozdemir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@willbush @TimJones @utkuozdemir @talos-bot