Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use s3 as state backend #43

Merged
merged 1 commit into from
May 6, 2024

Conversation

frezbo
Copy link
Member

@frezbo frezbo commented May 6, 2024

Use s3 as state backend.

@frezbo frezbo force-pushed the chore/use-s3-backend branch 2 times, most recently from c889199 to b3cb214 Compare May 6, 2024 07:04
Use s3 as state backend.

Signed-off-by: Noel Georgi <[email protected]>
@frezbo frezbo force-pushed the chore/use-s3-backend branch from b3cb214 to 0ad9f4c Compare May 6, 2024 08:40
@TimJones
Copy link
Member

TimJones commented May 6, 2024

Are we actually consuming these as modules somewhere? I assumed since they were examples they should be minimal and not implement this, leaving it rather up to the user.

@frezbo
Copy link
Member Author

frezbo commented May 6, 2024

Are we actually consuming these as modules somewhere? I assumed since they were examples they should be minimal and not implement this, leaving it rather up to the user.

yes, talos e2e tests uses them, I'm now in the process of porting talos over to GHA

@frezbo
Copy link
Member Author

frezbo commented May 6, 2024

also this is not part of tf code the user sees, hack directory 😅

@TimJones
Copy link
Member

TimJones commented May 6, 2024

In that case, wouldn't it make more sense to update the e2e tests to consume these as modules and set up the terraform backend there directly?

@frezbo
Copy link
Member Author

frezbo commented May 6, 2024

In that case, wouldn't it make more sense to update the e2e tests to consume these as modules and set up the terraform backend there directly?

trying to avoid adding tf code in talos repo

@frezbo
Copy link
Member Author

frezbo commented May 6, 2024

/m

@talos-bot talos-bot merged commit 0ad9f4c into siderolabs:main May 6, 2024
2 checks passed
@frezbo frezbo deleted the chore/use-s3-backend branch May 6, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants