Add support for setting int, string, color, file parameter on Houdini Asset Component in blueprint #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wywarren
commented
Apr 9, 2024
wywarren
commented
- Consider renaming SetToggleValueAt to SetToggleParameter to match existing naming convention as SetFloatParameter also uses indexes but is not verbose in the function name
… Asset Component in blueprint - Consider renaming SetToggleValueAt to SetToggleParameter to match existing naming convention as SetFloatParameter also uses indexes but is not verbose in the function name
wywarren
changed the title
…rameter with warning messages for existance checking - Getting for ToggleParameter is using function name GetToggleParameter instead of GetToggleValueAt - Consider adding a generic template for GetTypedValueAt. This would require consolidating more parameter types to use this function name though. Some do not have indexes as well so may want to add GetTypedValue function in the future for Parameters without index.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.