Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#982 Fix search bar #1080

Merged
merged 7 commits into from
Jul 23, 2024
Merged

#982 Fix search bar #1080

merged 7 commits into from
Jul 23, 2024

Conversation

Priyal208
Copy link
Contributor

Description

As mentioned in issue #982 assigned to me under gssoc'24 , I optimised the search bar which earlier gave not so appropriate results making it more user friendly.

Related Issues

#982

Changes Proposed

Additionaly I added a drop which allows users to select whether they want to serach by name, location or skill and then it gives specific results as per requirement only unlike earlier random results.

Checklist

  • I have read and followed the Contribution Guidelines.
  • All new and existing tests passed.
  • I have updated the documentation to reflect the changes I've made.
  • My code follows the code style of this project.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Screenshot 2024-07-10 191035
Screenshot 2024-07-10 191050
Screenshot 2024-07-10 191107

Note to reviewers

Kindly review it asap and give me appropriate level as I also additionaly added dropdown bar and made it most optimized. Thank you

Copy link

vercel bot commented Jul 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-find ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 0:31am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Priyal208! 🎉 Thank you for opening a pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.

@Priyal208
Copy link
Contributor Author

@shyamtawli kindly review it

@akbatra567
Copy link

akbatra567 commented Jul 12, 2024

Hello @Priyal208, Could you look into this scenario ?

We have a search string

  1. kolkata,india
  2. kolkata, india
    Just a difference of space is a giving us different result.

Screenshot 2024-07-13 at 12 50 32 AM
Screenshot 2024-07-13 at 12 50 15 AM

Issues with this is even if we have a match for the location, we won't be able to find if a comma or space is in different order.
P.S: This is one scenario for location, do check for other filters as well.

@Priyal208
Copy link
Contributor Author

@shyamtawli now pls you can check i fixed that problem of space giving different result for all test cases
You can see search queries before space and after space
Screenshot 2024-07-15 185710
Screenshot 2024-07-15 185719

@akbatra567 akbatra567 added GSSoC24 GSSoC GSSoC Contributions labels Jul 16, 2024
@akbatra567
Copy link

Hey @shyamtawli,
There is a scenario which doesn't work as of now:

  • If we would like to search multiple skills at once.
  • For example: Javascript, React

Do you need this to be handle in this PR, or we can create a new issue for that.

@Priyal208
Copy link
Contributor Author

@shyamtawli can you pls review this

Copy link
Owner

@shyamtawli shyamtawli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Priyal208 Can you improve the UI, currently it is not looking decent.

@Priyal208
Copy link
Contributor Author

@shyamtawli i did improve the UI u can see i added appropriate spacing, kindly merge the PR now, also pls see that you are assigning appropriate level as I did improve search operation, also added dropdown, even improved the UI
Screenshot 2024-07-22 125314
Screenshot 2024-07-22 125322

@shyamtawli shyamtawli added the level3 GSSoC Contributions Difficulty Level label Jul 23, 2024
@shyamtawli shyamtawli merged commit 5350cf6 into shyamtawli:master Jul 23, 2024
2 checks passed
@shyamtawli
Copy link
Owner

@Priyal208 Thank you so much for your contribution! Your efforts are greatly appreciated and will go a long way in improving our project. Please feel free to share it with others and help us grow even further!

@Priyal208
Copy link
Contributor Author

@shyamtawli sure thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSSoC GSSoC Contributions GSSoC24 level3 GSSoC Contributions Difficulty Level
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants