-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#982 Fix search bar #1080
#982 Fix search bar #1080
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @Priyal208! 🎉 Thank you for opening a pull request. Your contribution is valuable and we appreciate your efforts to improve our project.
Soon the maintainers/owner will review it and provide you with feedback/suggestions.
@shyamtawli kindly review it |
Hello @Priyal208, Could you look into this scenario ? We have a search string
Issues with this is even if we have a match for the location, we won't be able to find if a comma or space is in different order. |
@shyamtawli now pls you can check i fixed that problem of space giving different result for all test cases |
Hey @shyamtawli,
Do you need this to be handle in this PR, or we can create a new issue for that. |
@shyamtawli can you pls review this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Priyal208 Can you improve the UI, currently it is not looking decent.
@shyamtawli i did improve the UI u can see i added appropriate spacing, kindly merge the PR now, also pls see that you are assigning appropriate level as I did improve search operation, also added dropdown, even improved the UI |
@Priyal208 Thank you so much for your contribution! Your efforts are greatly appreciated and will go a long way in improving our project. Please feel free to share it with others and help us grow even further! |
@shyamtawli sure thanks |
Description
As mentioned in issue #982 assigned to me under gssoc'24 , I optimised the search bar which earlier gave not so appropriate results making it more user friendly.
Related Issues
#982
Changes Proposed
Additionaly I added a drop which allows users to select whether they want to serach by name, location or skill and then it gives specific results as per requirement only unlike earlier random results.
Checklist
Screenshots
Note to reviewers
Kindly review it asap and give me appropriate level as I also additionaly added dropdown bar and made it most optimized. Thank you