Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Os commit1 #1079

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Os commit1 #1079

wants to merge 3 commits into from

Conversation

AVINASH-X2
Copy link

@AVINASH-X2 AVINASH-X2 commented Jul 9, 2024

Contact Form Styling

  1. The Dark mode settings were not working for the contact page, the details written for the contact page were dark and white irrespective of the mode settings. With some changes in the contact form, I was able to fix this issue.
  2. The outline-none, made the contact form more user friendly.

Scroll Bug Removed

Once hovered on the skill divisions, the page doesn't allows any scrolling which is frustrating, with pointer-events-none, it's now scrollable and provides a smooth navigating experience.

Checklist

  • [ x ] I have read and followed the Contribution Guidelines.
  • [ x ] All new and existing tests passed.
  • [ x ] I have updated the documentation to reflect the changes I've made.
  • [ x ] My code follows the code style of this project.
  • [ x ] The title of my pull request is a short description of the requested changes.

Note to reviewers

My contribution mainly focuses on providing a better user experience. With the above changes mentioned the website provides a better navigation throughout the page.

I'd appreciate if you could merge these changes to your main branch.

Copy link

vercel bot commented Jul 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-find ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 7:23pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @AVINASH-X2! 🎉 Thank you for opening a pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant