Skip to content

Commit

Permalink
fixed [Bug]: On hovering card of users flickering issue #1095 & added… (
Browse files Browse the repository at this point in the history
#1121)

* fixed [Bug]: On hovering card of users flickering issue #1095 & added my profile to contribution

* Update ProfilesList.json

---------

Co-authored-by: Shyam Tawli <[email protected]>
  • Loading branch information
Arnavgarg68 and shyamtawli authored Oct 5, 2024
1 parent b750ffd commit d503002
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 2 deletions.
12 changes: 12 additions & 0 deletions public/data/ArnavGarg68.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"name": "Arnav Garg",
"location": "Meerut, India",
"bio": "A software developer with experience in MERN stack & JAVA",
"avatar": "https://avatars.githubusercontent.com/u/150692775?s=400&u=76946dcd293b4bb56766f09dd3aef7755bde3911&v=4",
"portfolio": "https://portfolio-gsap.onrender.com",
"skills": ["React ", "MongoDB", "Express", "JavaScript", "Node", "GSAP", "HTML", "CSS", "JAVA"],
"social": {
"GitHub": "https://github.com/Arnavgarg68",
"LinkedIn": "https://www.linkedin.com/in/arnav-garg-221h/"
}
}
3 changes: 2 additions & 1 deletion src/ProfilesList.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
[
"ArnavGarg68.json",
"samah554.json",
"mayurr7.json",
"vitormarinheiro.json",
Expand Down Expand Up @@ -444,4 +445,4 @@
"boytur.json",
"krtEngineer.json",
"giuliarappo.json"
]
]
2 changes: 1 addition & 1 deletion src/components/Profile/Profile.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ function Card({ data }) {
{data.location}
</p>
<div
className="skills-container mt-4 flex h-auto gap-4 overflow-hidden hover:overflow-x-scroll hover:scroll-smooth"
className="skills-container mt-4 flex h-auto gap-4 overflow-hidden hover:overflow-hidden hover:scroll-smooth"
ref={cardRef}
>
{data.skills &&
Expand Down

1 comment on commit d503002

@dylan-dot-c
Copy link
Contributor

@dylan-dot-c dylan-dot-c commented on d503002 Oct 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it overflow hidden??
What happens when they have more than enough skills to and can't fit in the box? How are we supposed to see the others?
@shyamtawli @Arnavgarg68

Please sign in to comment.