Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SG-36838 Python 2 removal #84

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

SG-36838 Python 2 removal #84

wants to merge 2 commits into from
+21 −27

Conversation

eduardoChaucaGallegos
Copy link
Contributor

@eduardoChaucaGallegos eduardoChaucaGallegos commented Dec 12, 2024 •
edited
Loading

Description:

  • six.PY2 removed
  • super() function now exists without params.

Test:

  • Open breakdown and check for any regressions.

image

@eduardoChaucaGallegos eduardoChaucaGallegos requested a review from a team December 12, 2024 16:01
julien-lang
julien-lang reviewed Dec 12, 2024
View reviewed changes
Copy link

@julien-lang julien-lang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one minor comment

python/tk_multi_breakdown2/dialog.py Outdated Show resolved Hide resolved
julien-lang
julien-lang approved these changes Dec 13, 2024
View reviewed changes
Copy link

@julien-lang julien-lang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-villavicencio-adsk carlos-villavicencio-adsk carlos-villavicencio-adsk approved these changes

@staceyoue staceyoue staceyoue approved these changes

@julien-lang julien-lang julien-lang approved these changes

@rob-aitchison rob-aitchison Awaiting requested review from rob-aitchison rob-aitchison is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eduardoChaucaGallegos @julien-lang @staceyoue @carlos-villavicencio-adsk