Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link dialog docs #807

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Link dialog docs #807

wants to merge 4 commits into from

Conversation

j0yu
Copy link

@j0yu j0yu commented Apr 30, 2021

Updated sgtk.Engine.show_* documentations with links and better return type docstrings

image

image

Changed

  • sgtk.Engine links to methods
  • Links for "Hiding the default Toolkit title bar" and "Modal dialogs and exit codes"
  • Explicit, linked return types

@j0yu j0yu force-pushed the link-dialog-docs branch from 6de264e to 98ef356 Compare July 12, 2021 13:52
@staceyoue staceyoue self-requested a review September 26, 2022 19:38
staceyoue
staceyoue approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@staceyoue staceyoue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @j0yu thanks for improving the docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staceyoue staceyoue staceyoue approved these changes

@000paradox000 000paradox000 Awaiting requested review from 000paradox000

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j0yu @staceyoue