-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SG-32061 Python3.7+ Syntax #297
Conversation
Thank you for that! Do you know why unit tests are failing? It seems they share the same root cause. |
…g // add httplib2 and certifi to requirements
8bf91dc
to
77a9d3a
Compare
I think I found the reason: CI tests relies on variables given by the |
Amazing! I have one question, since tk-core bundles python-api module, would it be an issue to have dependencies such as certifi not bundled as before? |
Indeed yes, It will not work as is. I made a PR for the |
Thank you for the clarification. If it's possible, can you split this work into two different PRs? We want to address these improvements separately. So ideally the extraction of the bundled dependencies can be reviewed outside of this scope. |
I split this PR in two A rebase will probably be required between the two merge to ensure there are no conflict between them |
Hi there,
I just saw through SG-31340-deprecation-py2 that py2 has officially been deprecated, so I updated the API to embrace a py3.7+ syntax
The biggest changes:
str.format