feat: Adds support for properly handling block_suggestion events #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a block_suggestion handling workflow that mimics the current InteractionHandler workflows. Add suggestionHandlers slice to slaccker struct. Adds SuggestionHandler and SuggetionHandlerMiddleware functions. Adds logic in the main slacker.Listen func to switch between generic Interactions and block_suggestion interaction types
|
@shomali11 I pass the socketmode.Request to the "private" handler, the only thing the user has to do is register a SuggestionHandler that returns a slack.OptionsResponse struct. Then we will .Ack() the Request on our end instead of requiring the user to do it. |
|
I think this conflicts with #154, can you fix and re-push? cc: @raed-shomali |
|
This was that PR but I will rebate and Mahe another PR to ensure there are
no merge conflicts.
…On Mon, Nov 6, 2023, 9:41 PM Raed Shomali ***@***.***> wrote:
Thanks @arusso <https://github.com/arusso>. @0xArch3r
<https://github.com/0xArch3r> and I spoke and he will try to create a new
PR that attempts to take care of this without the developer having to
manually calling the Ack.
—
Reply to this email directly, view it on GitHub
<#156 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APB5ZUFG7U55NARG6IW6OJLYDGNVVAVCNFSM6AAAAAA6XVDHTGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJXGMZTENJQGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a block_suggestion handling workflow that mimics the current InteractionHandler workflows. Add suggestionHandlers slice to slaccker struct. Adds SuggestionHandler and SuggetionHandlerMiddleware functions. Adds logic in the main slacker.Listen func to switch between generic Interactions and block_suggestion interaction types