Update website #130

qu1queee · 2024-09-17T13:56:31Z

Changes

This is a complete rewrite of the website, mainly the landing page and the footer.

Comes with the necessary changes for the CNCF on-boarding as well.

Pardon my lack of experience in this area.

Submitter Checklist

Includes tests if functionality changed/was added
Includes docs if changes are user-facing
Set a kind label on this PR
Release notes block has been filled in, or marked NONE

Release Notes

NONE

Full refactor if _index.md for new landing page

Include CNCF logo and more useful links

openshift-ci · 2024-09-17T13:56:36Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from qu1queee. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

adambkaplan

First reaction is I love the new look! So much cleaner and gets rid of that poor-res container ship.

I want to propose merging this into a feature branch for a few reasons:

The maintainers are working with the Linux Foundation to issue a public statement/press release on the move. Timing the website update/refresh with this announcement makes sense to me.
I noticed a few important accessibility issues related to color contrast. Some I could trace back to the .scss files easily. The one I couldn't quite find is the .scss used to render command line monospace. That color blends in with the background, whereas the color text for yaml seems to be fine.
There are a few formatting bits I found - as you noted, there are areas of improvement since you aren't an expert on HTML/CSS.

I'd prefer we merge what we have somewhere and invite the rest of the community to contribute. The Docsy/hugo upgrades alone pay off a huge amount of tech debt.

The only thing that I think we have to address before merge is the color contrast issues. I found a few on the main page, and

adambkaplan · 2024-09-17T16:06:03Z

Makefile

@@ -17,15 +17,17 @@ clean: ## clean the build assets
 install: ## install dependencies
 	bundle
 	npm install
+	hugo mod get
+	hugo mod graph
+	hugo mod get github.com/google/docsy


Nit - can we pin the version of Docsy with hugo mod get?

adambkaplan · 2024-09-17T16:06:19Z

Makefile

-netlify: submodule-init ## build the site for Netlify
-	git submodule update --init --recursive --depth 1


yay for no more submodules!

adambkaplan · 2024-09-17T16:07:19Z

config.toml

Note to myself (and for others benefit) - config.toml is now represented in hugo.yaml

adambkaplan · 2024-09-17T16:08:52Z

content/en/_index.html

+		<h2>Shipwright supports popular tools such as ko, Cloud Native Buildpacks, and more!
+			<br> to build your container images.</h2>


For follow-up, line breaks and layout should be managed with CSS.

adambkaplan · 2024-09-17T16:12:01Z

Gemfile.lock

@@ -4,6 +4,7 @@ GEM
    asciidoctor (2.0.17)

 PLATFORMS
+  universal-darwin-23


Ack that this allows developers to test on Apple devices.

adambkaplan · 2024-09-17T16:17:04Z

assets/scss/_styles_project.scss

+    gap: 0.25rem;
+    margin-bottom: 1rem;
+    display: grid;
+    color: #28384b;


UX/accessibility issue - this color does not have strong enough contrast with the .lead-block-container background color.

adambkaplan · 2024-09-17T16:18:49Z

assets/scss/_styles_project.scss

+    text-align: left;
+    line-height: 100%;
+    letter-spacing: 0.62px;
+    color: #28384b;


UX/accessibility issue - not enough contrast with background

adambkaplan · 2024-09-17T16:20:51Z

assets/scss/_styles_project.scss

+    line-height: 1.6;
+    margin-bottom: 1.5rem;
+    margin-left: 0.41rem;
+    color: #7e93a7;


UX/accessibility issue - not enough contrast with background

openshift-merge-robot · 2024-09-27T23:29:43Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

qu1queee added 9 commits September 17, 2024 15:49

move into hugo.yaml

b9f209d

move into hugo modules

077e5a0

remove submodule

4403f06

Modify content

b0c8fb0

Full refactor if _index.md for new landing page

Modify footer

f1192f5

Include CNCF logo and more useful links

add images

89e35f5

add scss code

c9ade28

add 404 html code

4787294

update Gemfile

09c42c0

openshift-ci bot requested review from HeavyWombat and SaschaSchwarze0 September 17, 2024 13:56

pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 17, 2024

qu1queee added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 17, 2024

pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 17, 2024

qu1queee force-pushed the qu1queee/update_website branch 3 times, most recently from 4804357 to ff9773a Compare September 17, 2024 14:34

update Makefile and deps

8ad7bbb

qu1queee force-pushed the qu1queee/update_website branch from ff9773a to 8ad7bbb Compare September 17, 2024 14:36

qu1queee added 2 commits September 17, 2024 16:42

fix images ref and location

8cc310f

improve colors for footer text

8417e6e

qu1queee requested review from adambkaplan and removed request for HeavyWombat and SaschaSchwarze0 September 17, 2024 15:12

qu1queee mentioned this pull request Sep 17, 2024

CNCF Onboarding Checklist shipwright-io/community#240

Open

22 tasks

adambkaplan requested changes Sep 17, 2024

View reviewed changes

qu1queee marked this pull request as draft September 19, 2024 06:20

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 19, 2024

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update website #130

Update website #130

qu1queee commented Sep 17, 2024

openshift-ci bot commented Sep 17, 2024

adambkaplan left a comment

adambkaplan Sep 17, 2024

adambkaplan Sep 17, 2024

adambkaplan Sep 17, 2024

adambkaplan Sep 17, 2024

adambkaplan Sep 17, 2024

adambkaplan Sep 17, 2024

adambkaplan Sep 17, 2024

adambkaplan Sep 17, 2024

openshift-merge-robot commented Sep 27, 2024

		netlify: submodule-init ## build the site for Netlify
		git submodule update --init --recursive --depth 1

		<h2>Shipwright supports popular tools such as ko, Cloud Native Buildpacks, and more!
		<br> to build your container images.</h2>

Update website #130

Are you sure you want to change the base?

Update website #130

Conversation

qu1queee commented Sep 17, 2024

Changes

Submitter Checklist

Release Notes

openshift-ci bot commented Sep 17, 2024

adambkaplan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

openshift-merge-robot commented Sep 27, 2024