Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for the multiarch-native-buildah ClusterStrategy #125

Closed

Conversation

aleskandro
Copy link

@aleskandro aleskandro commented Jul 25, 2024

This PR proposes a new paragraph to document the Multiarch Native Buildah strategy proposed in shipwright-io/build#1634.

I see the other strategies leverage a relative path to link to the strategy in the document; however, those links are dead, AFAICU.

Therefore, I used GitHub permalinks. Are they okay with landing in the doc?

Note: the permalinks may need to be updated once shipwright-io/build#1634 lands.

Relates to shipwright-io/build#1119

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 25, 2024
Copy link
Contributor

openshift-ci bot commented Jul 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign qu1queee for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aleskandro aleskandro force-pushed the multiarch-native-builds branch 4 times, most recently from a50214b to 52c715b Compare July 25, 2024 16:14
@aleskandro
Copy link
Author

Updated the TOC

Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aleskandro
Copy link
Author

Opened shipwright-io/build#1660

@aleskandro aleskandro closed this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants