Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blog for vulnerability scanning in shipwright #123

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Add blog for vulnerability scanning in shipwright #123

merged 2 commits into from
Jul 16, 2024

Conversation

karanibm6
Copy link
Contributor

Changes

  • Add blog for vulnerability scanning in shipwright

Submitter Checklist

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Add blog for vulnerability scanning in shipwright

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 14, 2024
@karanibm6
Copy link
Contributor Author

/kind blog

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 14, 2024

@karanibm6: The label(s) kind/blog cannot be applied, because the repository doesn't have them.

In response to this:

/kind blog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@karanibm6 karanibm6 force-pushed the vulnerability-scanning-blog branch from ad1ae7c to 0fa9076 Compare July 14, 2024 20:27
@qu1queee qu1queee self-requested a review July 15, 2024 11:29
adambkaplan
adambkaplan approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

I may need to re-kick the deploy preview later today to see the post. Alternatively, @karanibm6 you can set the timestamp to midnight UTC and the post should render in the preview.

content/en/blog/posts/2024-07-15-vulnerability-scanning.md Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2024
@karanibm6 karanibm6 force-pushed the vulnerability-scanning-blog branch from 0fa9076 to ac02d62 Compare July 16, 2024 01:22
qu1queee
qu1queee requested changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing post! I enjoyed reading it!

content/en/blog/posts/2024-07-15-vulnerability-scanning.md Outdated Show resolved Hide resolved
content/en/blog/posts/2024-07-15-vulnerability-scanning.md Outdated Show resolved Hide resolved
content/en/blog/posts/2024-07-15-vulnerability-scanning.md Outdated Show resolved Hide resolved
content/en/blog/posts/2024-07-15-vulnerability-scanning.md Show resolved Hide resolved
content/en/blog/posts/2024-07-15-vulnerability-scanning.md Outdated Show resolved Hide resolved
content/en/blog/posts/2024-07-15-vulnerability-scanning.md Outdated Show resolved Hide resolved
content/en/blog/posts/2024-07-15-vulnerability-scanning.md Outdated Show resolved Hide resolved
content/en/blog/posts/2024-07-15-vulnerability-scanning.md Outdated Show resolved Hide resolved
content/en/blog/posts/2024-07-15-vulnerability-scanning.md Outdated Show resolved Hide resolved
content/en/blog/posts/2024-07-15-vulnerability-scanning.md Outdated Show resolved Hide resolved
@karanibm6 karanibm6 force-pushed the vulnerability-scanning-blog branch from c4e6419 to 3c3dba6 Compare July 16, 2024 08:16
@karanibm6 karanibm6 force-pushed the vulnerability-scanning-blog branch from 3c3dba6 to 0cc9baf Compare July 16, 2024 08:18
@karanibm6 karanibm6 requested a review from qu1queee July 16, 2024 08:18
qu1queee
qu1queee approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, qu1queee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adambkaplan,qu1queee]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 874e44b into shipwright-io:main Jul 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qu1queee qu1queee qu1queee approved these changes

@adambkaplan adambkaplan adambkaplan approved these changes

@rolfedh rolfedh Awaiting requested review from rolfedh

@SaschaSchwarze0 SaschaSchwarze0 Awaiting requested review from SaschaSchwarze0

Assignees

@qu1queee qu1queee

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Shipwright Overview
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karanibm6 @adambkaplan @qu1queee