Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add post on beta API and migration guidelines #107

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

qu1queee
Copy link
Contributor

@qu1queee qu1queee commented Nov 7, 2023

Changes

Add blog post on beta API

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Add blog post with migration guidelines for beta API.

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 7, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2023
@qu1queee qu1queee force-pushed the qu1queee/beta_api branch 3 times, most recently from 5767076 to b1d7795 Compare November 8, 2023 09:53
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 8, 2023
@qu1queee qu1queee added the kind/documentation Categorizes issue or PR as related to documentation. label Nov 8, 2023
@qu1queee qu1queee marked this pull request as ready for review November 8, 2023 12:34
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 8, 2023
Copy link
Contributor

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @qu1queee. Nice work again! I've offered some minor suggestions.

content/en/blog/posts/2023-11-07-beta-api.md Outdated Show resolved Hide resolved
content/en/blog/posts/2023-11-07-beta-api.md Outdated Show resolved Hide resolved
content/en/blog/posts/2023-11-07-beta-api.md Outdated Show resolved Hide resolved
content/en/blog/posts/2023-11-07-beta-api.md Outdated Show resolved Hide resolved
content/en/blog/posts/2023-11-07-beta-api.md Outdated Show resolved Hide resolved
Co-authored-by: Rolfe Dlugy-Hegwer <[email protected]>
@qu1queee
Copy link
Contributor Author

qu1queee commented Nov 8, 2023

thanks @rolfedh !

@qu1queee qu1queee requested a review from rolfedh November 8, 2023 17:38
Copy link
Contributor

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Looks great! The generated service accounts item got me thinking about new features and deprecations. It's been a while - anything worth reporting beyond the beta API?

content/en/blog/posts/2023-11-07-beta-api.md Outdated Show resolved Hide resolved

We strongly encourage both current and future users to adopt the _beta_ API to benefit from
its enhanced definition.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any other notable new features? Deprecations?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very few, like improvements in terms of security for the pods running on the shipwright-build namespace. I think is fine not adding them here, as this one focus more on the beta API only.

Copy link
Contributor

openshift-ci bot commented Nov 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2023
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit f340d8b into main Nov 13, 2023
5 checks passed
@qu1queee qu1queee deleted the qu1queee/beta_api branch November 13, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants