Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shipwright-io/setup@v2 #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

shipwright-io/setup@v2 #8

wants to merge 1 commit into from

Conversation

otaviof
Copy link
Member

@otaviof otaviof commented Nov 18, 2022

Changes

Updating examples before releasing v2.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

NONE

@openshift-ci
Copy link

openshift-ci bot commented Nov 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: otaviof

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2022
@otaviof
Copy link
Member Author

otaviof commented Nov 18, 2022

/assign @SaschaSchwarze0

@otaviof
Copy link
Member Author

otaviof commented Nov 18, 2022

/hold let's start using shipwright-io/setup@main before a new release here, as spoken with @SaschaSchwarze0 this afternoon.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@ricardomaraschini ricardomaraschini Awaiting requested review from ricardomaraschini

At least 1 approving review is required to merge this pull request.

Assignees

@SaschaSchwarze0 SaschaSchwarze0

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@otaviof @SaschaSchwarze0