Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Only allow one instance of ShipwrightBuild #150

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kevydotvinu
Copy link
Contributor

@kevydotvinu kevydotvinu commented Oct 17, 2023

Changes

  • Ignore and delete the second instance

Fixes #153

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

NONE

- Ignore and delete the second instance
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign qu1queee for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jkhelil
Copy link
Contributor

jkhelil commented Oct 18, 2023

Thank you @kevydotvinu for adding your contribution.
A few points related to your PR:

  • first it is valid point to ensure that we have once instance of shipwright-build CR
  • we need to have an approach where we fix the name of the CR,and validate that name before any reonciliation (shipwright-config)
  • we would then include a targetNamespace reconcile function, that deletes the old resources if the target namespace changes
  • The change needs a release note and docs update

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 1, 2023
@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kevydotvinu
Copy link
Contributor Author

Hello @jkhelil, thanks for reviewing. Sure, I will add those changes.

@qu1queee qu1queee requested review from adambkaplan and removed request for qu1queee November 20, 2023 07:48
@adambkaplan
Copy link
Member

@kevydotvinu please let us know if you have the time to work on this PR further. We plan on doing a significant refactor soon which will make this pull request very obsolete and hard to rebase.

@sayan-biswas
Copy link

IMO, using webhook is a better user experience for this use case.

@kevydotvinu
Copy link
Contributor Author

I will work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[FEATURE] Only one instance of ShipwrightBuild kind should be allowed on a given cluster
5 participants