-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Only allow one instance of ShipwrightBuild
#150
base: main
Are you sure you want to change the base?
Conversation
- Ignore and delete the second instance
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you @kevydotvinu for adding your contribution.
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hello @jkhelil, thanks for reviewing. Sure, I will add those changes. |
@kevydotvinu please let us know if you have the time to work on this PR further. We plan on doing a significant refactor soon which will make this pull request very obsolete and hard to rebase. |
IMO, using webhook is a better user experience for this use case. |
I will work on it. |
Changes
Fixes #153
Submitter Checklist
Release Notes