Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improved error messaging for Nonexistent namespaces,builds and buildr… #278

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

improved error messaging for Nonexistent namespaces,builds and buildr… #278

wants to merge 2 commits into from

Conversation

Adarsh-jaiss
Copy link
Member

Changes

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 9, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign saschaschwarze0 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Adarsh-jaiss Adarsh-jaiss mentioned this pull request Sep 9, 2024
Open
1 task
SaschaSchwarze0
SaschaSchwarze0 reviewed Sep 10, 2024
View reviewed changes
pkg/shp/cmd/build/list.go Outdated Show resolved Hide resolved
pkg/shp/cmd/build/list.go Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 10, 2024
@Adarsh-jaiss
added suggested changes
c6b61e8 
Signed-off-by: adarsh-jaiss <[email protected]>

added suggested changes

Signed-off-by: adarsh-jaiss <[email protected]>
@Adarsh-jaiss
Copy link
Member Author

Adarsh-jaiss commented Sep 10, 2024 •
edited
Loading

@qu1queee qu1queee self-requested a review September 10, 2024 10:13
qu1queee
qu1queee approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qu1queee qu1queee qu1queee approved these changes

@HeavyWombat HeavyWombat Awaiting requested review from HeavyWombat

@SaschaSchwarze0 SaschaSchwarze0 Awaiting requested review from SaschaSchwarze0

Assignees

@qu1queee qu1queee

Labels
lgtm Indicates that a PR is ready to be merged. release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Shipwright Overview
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Improved Error Messaging for Nonexistent Namespaces in Shipwright CLI
3 participants
@Adarsh-jaiss @qu1queee @SaschaSchwarze0