Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds flag to add paramValues #274

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

apoorvajagtap
Copy link
Member

@apoorvajagtap apoorvajagtap commented Aug 7, 2024

Changes

This commit enables the option to pass custom/required parameters via CLI while creating the build or buildRun.
Fixes #224

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

Shipwright CLI extends support to set the parameters using "--param-value" flag while creating build/buildRun.

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 7, 2024
Copy link
Contributor

openshift-ci bot commented Aug 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign adambkaplan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This commit enables the option to pass custom/required parameters
via CLI while creating the build or buildRun.
@adambkaplan
Copy link
Member

@apoorvajagtap please rebase this pull request. The verify check was fixed in #277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[FEATURE] Support for parameters, part 1
2 participants